[wp-trac] [WordPress Trac] #34527: WP oEmbed: the iframe height attribute doesn't need "px"
WordPress Trac
noreply at wordpress.org
Sat Oct 31 14:29:21 UTC 2015
#34527: WP oEmbed: the iframe height attribute doesn't need "px"
---------------------------------------+-----------------------------
Reporter: afercia | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.4
Component: Embeds | Version: trunk
Severity: normal | Resolution:
Keywords: has-screenshots has-patch | Focuses: ui, javascript
---------------------------------------+-----------------------------
Comment (by swissspidy):
Introduced back in August, see https://github.com/swissspidy/oEmbed-
API/commit/4afbd5f4fa382b5f0afa4f34b9d4cb1dd678bc88.
While looking at this now, I think we should make sure that `height` is an
actual number, to prevent setting the height to anything else. See
[attachment:34527.2.patch]
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34527#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list