[wp-trac] [WordPress Trac] #34484: WP oEmbed: Sharing dialog accessibility improvements

[WordPress Trac]

#34484: WP oEmbed: Sharing dialog accessibility improvements
------------------------------+--------------------------------------------
 Reporter:  afercia           |       Owner:  afercia
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.4
Component:  Embeds            |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  ui, accessibility, javascript
------------------------------+--------------------------------------------
Changes (by swissspidy):

 * keywords:  has-patch needs-testing => has-patch commit
 * owner:   => afercia
 * status:  new => assigned


Comment:

 Replying to [comment:4 afercia]:
 > Consider users can open, close and re-open the dialog multiple times, so
 it made sense for me to re-get the current Tab each time when opening the
 dialog :)

 I was more thinking that it makes sense to "start fresh" when opening the
 dialog again, but after further testing it with a screen reader (I used
 ChromeVox) your approach (and as it is now) makes more sense.
 [attachment:34484.3.patch] changes the selector again.

 ChromeVox read the actions correctly when opening and navigating inside
 the sharing dialog ("tab 1 of 2 selected", etc.). It was an interesting
 experience btw :)

 Im my opinion this is good to go.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34484#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform