[wp-trac] [WordPress Trac] #34484: WP oEmbed: Sharing dialog accessibility improvements

[WordPress Trac]

#34484: WP oEmbed: Sharing dialog accessibility improvements
------------------------------+--------------------------------------------
 Reporter:  afercia           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.4
Component:  Embeds            |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch needs-  |     Focuses:  ui, accessibility, javascript
  testing                     |
------------------------------+--------------------------------------------

Comment (by afercia):

 Noticed one thing: `openSharingDialog` should not assume the current Tab
 is the first one. That's why in teh first patch I used:
 {{{
 document.querySelector( '.wp-embed-share-tab-button [aria-
 selected="true"]' ).focus();
 }}}
 Consider users can open, close and re-open the dialog multiple times, for
 example:
 - open the dialog
 - switch to the second Tab
 - press Escape, the dialog closes
 - open the dialog again
 - at this point the current Tab is the second one
 so it made sense for me to re-get the current Tab each time when opening
 the dialog :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34484#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform