[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS
WordPress Trac
noreply at wordpress.org
Sat Oct 17 22:00:02 UTC 2015
#34204: Add fallbacks for WP oEmbed JavaScript & CSS
---------------------------+-------------------------
Reporter: peterwilsoncc | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.4
Component: Embeds | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
---------------------------+-------------------------
Comment (by peterwilsoncc):
Replying to [comment:21 swissspidy]:
> There's no `print_embed_styles` hook.
>
> `print_emoji_styles` is already hooked to `wp_print_styles` so the
styles are already loaded.
> [attachment:34204.diff] correctly hooks `enqueue_embed_scripts` to
`embed_head` instead of `oembed_head`.
Thanks, missed both of these.
Looks like there is both `print_embed_styles`
[https://core.trac.wordpress.org/browser/trunk/src/wp-includes/default-
filters.php#L451 L451] and `wp_print_styles`
[https://core.trac.wordpress.org/browser/trunk/src/wp-includes/default-
filters.php#L454 L454] on the `embed_head` hook. Should this be the case
or should one be removed?
> Also, now that I'm working on it, we should leave the other hooks as-is.
>
> Thanks for the info re: the `no-js` class. In the admin it's added to
the body, but I think here it's fine on the html embed.
Cool, now I see where you were coming from. Ta.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list