[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS

WordPress Trac noreply at wordpress.org
Thu Oct 15 21:33:03 UTC 2015


#34204: Add fallbacks for WP oEmbed JavaScript & CSS
---------------------------+-------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.4
Component:  Embeds         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript
---------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch needs-refresh => has-patch


Comment:

 Apologies for the missed files, refreshed in [attachment:34204.4.diff].

 The `no-js`/`js` classes indicates whether the browser passes the feature
 tests & can add events for the popup. It should only change if the
 features pass.

 Perhaps the answer is better class names:
 * `queryselector-(un)supported`
 * `w3events-(un)supported`

 Please make suggestions, naming things is hard.

 ~

 `featuredBrowser` is required in the event a visitor hits the embed HTML
 directly, eg http://wordpress-develop.dev/?p=1&embed=true

 ~

 Enqueueing open-sans moved.

 ~

 If this is committed prior to #34272, #34272 will require a refresh.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list