[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS

[WordPress Trac]

#34204: Add fallbacks for WP oEmbed JavaScript & CSS
-------------------------------------+-------------------------
 Reporter:  peterwilsoncc            |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.4
Component:  Embeds                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  javascript
-------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 Thanks for digging into all this!

 +1 for only showing the share icon if JavaScript is working.

 Some minor notes:

 * `wp-oembed-embed-ie.css` is missing from your latest patch
 * Can you move `wp_enqueue_style( 'open-sans' );` to
 `wp_oembed_enqueue_scripts` too?
 * `no-js` class should always be removed (or better: renamed to `js`,
 regardless of `featuredBrowser`
 * Is `featuredBrowser` even needed? It's always `true` since the JS isn't
 run in IE8 and lower.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform