[wp-trac] [WordPress Trac] #34653: TypeError: undefined is not an object (evaluating '$pass1Text.prop')

[WordPress Trac]

#34653: TypeError: undefined is not an object (evaluating '$pass1Text.prop')
-----------------------------------+------------------------------
 Reporter:  johnjamesjacoby        |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Users                  |     Version:  4.3
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:  javascript
-----------------------------------+------------------------------

Comment (by adamsilverstein):

 Replying to [comment:1 johnjamesjacoby]:

 > Another approach might be to set `$pass1Text` in `bindPasswordForm`
 first, before calling `bindPass1`, but I'm not yet confident that won't
 break other things.

 Your fix seems reasonable here, although I'm not sure I understand exactly
 how this happens in your plugin-  I will try it to see.

 I think you could safely set up `$pass1Text` in the outer scope without
 breaking anything.

 Another idea that might better enable reuse would be changing the startup
 so the script is triggered manually for each use (instead of on script
 load), then you could probably trigger it when you needed it. Might also
 make sense to break out into a separate file since we use it other
 contexts besides user profile page (install, soon pw reset, etc.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34653#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform