[wp-trac] [WordPress Trac] #34653: TypeError: undefined is not an object (evaluating '$pass1Text.prop')

[WordPress Trac]

#34653: TypeError: undefined is not an object (evaluating '$pass1Text.prop')
-----------------------------------+------------------------------
 Reporter:  johnjamesjacoby        |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Users                  |     Version:  4.3
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:  javascript
-----------------------------------+------------------------------

Comment (by johnjamesjacoby):

 The above patch takes the easy way out, and only touches the offending
 line of code causing the Javascript error. The issue is a bit complex
 otherwise, and I'm not sure this error necessitates a refactor of this
 code as it exists today.

 * `$pass1Text` is only set when `bindPass1` is called
 * `bindPasswordForm` only calls `bindPass1` if `$pass1` is not empty
 * `bindPasswordForm` sets all of the other variables that are used within
 that scope

 Another approach might be to set `$pass1Text` in `bindPasswordForm` first,
 before calling `bindPass1`, but I'm not yet confident that won't break
 other things.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34653#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform