[wp-trac] [WordPress Trac] #33465: plugin install button text is too large for display

[WordPress Trac]

#33465: plugin install button text is too large for display
------------------------------+--------------------------------------------
 Reporter:  mehulkaklotar     |       Owner:  afercia
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.4
Component:  Plugins           |     Version:  4.3
 Severity:  normal            |  Resolution:
 Keywords:  has-patch ui-     |     Focuses:  ui, accessibility, javascript
  feedback                    |
------------------------------+--------------------------------------------

Comment (by afercia):

 @melchoyce thanks for your feedback :) In the refreshed patch, tried to
 address some of your points.

 > 1. Is the error notice using `border-left` for the red border? Can it
 use `box-shadow` instead so the corner doesn't indent into a triangle?
 It uses the default `.notice-error` class but I've changed the notice top
 border which now it's done with box-shadow so the left border corner
 should have "squared" angles

 > 2. It looks like the close dashicon is being cut off on the top and
 bottom
 Unfortunately this is because the `.is-dismissible` class sets the
 dashicon font size to `16px` and as you know dashicons don't render in an
 optimal way when they're not set to their default font size (20px)

 > 3. Can we bold "Update Failed?"
 Sure.

 > 4. Might be worth trying the notice styling from #32244.
 Oh yes the white on white thing. Added the `notice-alt` class.

 Also, I missed to remove the notice when clicking again on the button. The
 previous patch appended multiple notice below the card when clicking again
 the button after the first error :)

 Screenshot with the refreshed patch applied:

 [[Image(https://cldup.com/DSG1s4uS3B.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33465#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform