[wp-trac] [WordPress Trac] #33465: plugin install button text is too large for display

WordPress Trac noreply at wordpress.org
Fri Nov 6 20:05:12 UTC 2015


#33465: plugin install button text is too large for display
------------------------------+--------------------------------------------
 Reporter:  mehulkaklotar     |       Owner:  afercia
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.4
Component:  Plugins           |     Version:  4.3
 Severity:  normal            |  Resolution:
 Keywords:  has-patch ui-     |     Focuses:  ui, accessibility, javascript
  feedback                    |
------------------------------+--------------------------------------------

Comment (by melchoyce):

 Replying to [comment:16 afercia]:
 > Refreshed patch. I went ahead and styled the notice, which is also
 dismissible now: click on the dismiss "X" button and the notice will be
 removed making the plugin card footer reappear.
 > Uses a custom event and wraps the dismissible-notice JavaScript in a
 named function.

 This is a good approach. More consistent with the rest of the admin UI
 than my original mockup: https://cloudup.com/c8KfL55uGqo

 Some notes:
 1. Is the error notice using `border-left` for the red border? Can it use
 `box-shadow` instead so the corner doesn't indent into a triangle?
 2. It looks like the close dashicon is being cut off on the top and bottom
 3. Can we bold "Update Failed?"
 4. Might be worth trying the notice styling from #32244.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33465#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list