[wp-trac] [WordPress Trac] #32503: Remove the "Update siteurl and home as well" checkbox option on multisite "Edit Site" screen.

[WordPress Trac]

#32503: Remove the "Update siteurl and home as well" checkbox option on multisite
"Edit Site" screen.
--------------------------------+----------------------------
 Reporter:  hugobaeta           |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  4.3
Component:  Networks and Sites  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  ui, multisite
--------------------------------+----------------------------
Changes (by jeremyfelt):

 * type:  defect (bug) => enhancement
 * milestone:  Awaiting Review => 4.3


Comment:

 Replying to [comment:6 earnjam]:
 > Perhaps we could just update both `home` and `site_url` automatically if
 they are the same and equal to the previous value of `domain``path` and
 don't update them if `home` and `site_url` are different.

 This seems pretty right on. We can remove the checkbox entirely and then
 treat the logic during update as:

 * If previous `domain + path (from wp_blogs) === domain + path (from
 siteurl)`, update `siteurl`.
 * If previous `domain + path (from wp_blogs) === domain + path (from
 home)`, update `home`.

 If somebody already has a different `siteurl` or `home`, it won't track
 the site changes and we won't break anything. If somebody purposefully
 alters `home` or `siteurl`, changes will stop tracking and they're on
 their own.

 At some point we'll also want to maintain the relationship after a scheme
 change by comparing `domain + path` and scheme separately. If the only
 difference when editing the site is a change from HTTP to HTTPS, that
 should be reflected. This, of course, relies on #14172 for tracking scheme
 at the `wp_blogs` level in the first place and shouldn't necessary be part
 of this ticket's patch if it can go in first.

 >  The downside of that is that it's confusing because now we have 4
 separate values set in 2 locations and changing the `domain``path` values
 on `site-info.php` wouldn't really do anything practical. It would just
 change the values in `wp_blogs`

 The `wp_blogs` data is the most important part though, as it's what our
 bootstrap uses to find the site originally.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32503#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform