[wp-trac] [WordPress Trac] #25408: Ability to specify that a list table column is "primary"
WordPress Trac
noreply at wordpress.org
Sun May 24 23:42:03 UTC 2015
#25408: Ability to specify that a list table column is "primary"
-----------------------------------------------+-----------------------
Reporter: helen | Owner: stephdau
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.3
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing 4.1-early | Focuses:
-----------------------------------------------+-----------------------
Comment (by afercia):
Replying to [comment:23 stephdau]:
> Personally, as a dev, I'd like both a generic with context as arg (as
per prev patch), or one as you describe (context via dynamic hook name). I
see value in both. Passing it as an arg is what @helen and I had decided
for this round, but I'm not attached to either.
I'm not attached to either too :) just a bit concerned about consistency
with other similar hooks noticing that they all have a dynamic hook name.
> > - in /network/users.php the "Sites" column needs some special
treatment, it needs the "has-row-actions" CSS class (links not revealed on
focus see #31003 for reference)
> I can do that, but I don't understand what you mean.
One of the side goals of this ticket would be replacing in common.js that
"terrible selectors pile" as @helen named it :) with just one CSS
selector. See:
https://core.trac.wordpress.org/browser/tags/4.2/src/wp-
admin/js/common.js#L481
should use as selector just ".has-row-actions". Once you do that, the
edit/view links in the "Sites" column won't show on keyboard focus because
that column is not the primary one and doesn't have a ".has-row-actions"
class.
> > - consider to update the selector in common.js
> I'm not sure what that really means per se.
See above :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25408#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list