[wp-trac] [WordPress Trac] #25408: Ability to specify that a list table column is "primary"

[WordPress Trac]

#25408: Ability to specify that a list table column is "primary"
-----------------------------------------------+-----------------------
 Reporter:  helen                              |       Owner:  stephdau
     Type:  enhancement                        |      Status:  assigned
 Priority:  normal                             |   Milestone:  4.3
Component:  Administration                     |     Version:
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch needs-testing 4.1-early  |     Focuses:
-----------------------------------------------+-----------------------

Comment (by stephdau):

 Replying to [comment:22 afercia]:
 > Tested a bit the patch, thanks very much @stephdau :)
 Thank YOU, for the testing. :)
 Added new patch: [attachment:25408.6.diff]. See further info below below.

 > Noticed a few things worth considering:
 > - small typo: for Posts/Pages the default primary column is set to
 "author"
 Fixed in new patch, thanks. Guess that was set to my last test. :)

 > - wouldn't be better to use `$this->screen->id` as dynamic portion of
 the hook name?
 > - doing the above, would we really need to pass `$this->screen->id` as
 additional variable?
 Personally, as a dev, I'd like both a generic with context as arg (as per
 prev patch), or one as you describe (context via dynamic hook name). I see
 value in both. Passing it as an arg is what @helen and I had decided for
 this round, but I'm not attached to either. See
 `WP_List_Table::get_primary_column_name()` in new patch for an example of
 both, from which we can decide.

 > - in /network/users.php the "Sites" column needs some special treatment,
 it needs the "has-row-actions" CSS class (links not revealed on focus see
 #31003 for reference)
 I can do that, but I don't understand what you mean. See
 https://cloudup.com/c5p3yXllT7K
  * 1st screenshot is with `username` as primary, edit/view show on kb
 focus of blog url)
  * 2nd screenshot is with `blogs` as primary, edit/view also show next to
 url, then edit link (only action for user) shows underneath the blogs
 list.

 > - is it worth it to apply all this new stuff to Link Manager too?
 Can do, so long as we're cool with the logic. I'd assume yes. Original
 patches I started from didn't address it, not sure why.

 > - consider to update the selector in common.js
 I'm not sure what that really means per se. :) Could you apply the patch,
 make your change, add it to the patch, and submit it, so I can see?

 Thanks.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25408#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform