[wp-trac] [WordPress Trac] #26600: Search installed themes input has no submit button

WordPress Trac noreply at wordpress.org
Tue Mar 31 16:10:37 UTC 2015

#26600: Search installed themes input has no submit button
 Reporter:  grahamarmfield        |       Owner:  SergeyBiryukov
     Type:  defect (bug)          |      Status:  reviewing
 Priority:  normal                |   Milestone:  4.2
Component:  Themes                |     Version:  3.8
 Severity:  normal                |  Resolution:
 Keywords:  has-patch dev-        |     Focuses:  accessibility, javascript
  feedback                        |

Comment (by afercia):

 Replying to [comment:51 adamsilverstein]:
 > I think you need more than keyup to cover some edge cases: pasting text
 into search would be a change event. I'll dig into what search is, not
 Makes sense, but then we should do the same for
 `themes.view.InstallerSearch` where there's only this:
 events: {
         'keyup': 'search'


 > by debouncing the search event, we prevent the events from multi-firing,
 so when keyup and change are triggered one after another only one search
 gets executed, and wp.speak should only run once.
 Not sure about this :) the keyup event needs to multi-fire, actually it's
 how we can detect users are still typing and `doSearch` needs to be
 continuously called and should be debounced. See #31812. Working on a
 patch, seems to work as intended but for sure we need to increase the
 "wait" interval to at least 500 ms, same value already used in wpLink:
 includes/js/wplink.js?rev=31606#L67 or probably even more than 500 (at
 least for the installer search).

Ticket URL: <https://core.trac.wordpress.org/ticket/26600#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list