[wp-trac] [WordPress Trac] #26600: Search installed themes input has no submit button

[WordPress Trac]

#26600: Search installed themes input has no submit button
----------------------------------+----------------------------------------
 Reporter:  grahamarmfield        |       Owner:  SergeyBiryukov
     Type:  defect (bug)          |      Status:  reviewing
 Priority:  normal                |   Milestone:  4.2
Component:  Themes                |     Version:  3.8
 Severity:  normal                |  Resolution:
 Keywords:  has-patch dev-        |     Focuses:  accessibility, javascript
  feedback                        |
----------------------------------+----------------------------------------

Comment (by adamsilverstein):

 I think you need more than keyup to cover some edge cases: pasting text
 into search would be a change event. I'll dig into what search is, not
 sure; by debouncing the search event, we prevent the events from multi-
 firing, so when keyup and change are triggered one after another only one
 search gets executed, and wp.speak should only run once.


 Replying to [comment:50 afercia]:
 > Replying to [comment:49 helen]:
 > Thanks @helen and @evansolomon :) I'd say also for the
 `themes.Collection` the debounce should be set on `doSearch` not on
 `search`. To my understanding, it's the `doSearch` function that needs to
 be continuously called and then it will be called after it stops being
 called, i.e. when users stop typing.
 >
 > Also, I'm not sure about all that events bound on the
 `themes.view.Search`
 > {{{
 > events: {
 >       'input':  'search',
 >       'keyup':  'search',
 >       'change': 'search',
 >       'search': 'search',
 >       'blur':   'pushState'
 > },
 > }}}
 > they look a bit too many to me :) wouldn't 'keyup' suffice? added in
 r26291. And can't get what the 'search' event is there, but maybe I'm
 missing something.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26600#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform