[wp-trac] [WordPress Trac] #29958: collapse menu keyboard accessibility

[WordPress Trac]

#29958: collapse menu keyboard accessibility
--------------------------+------------------------------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:                |     Version:  4.0
  Administration          |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  needs-        |
  testing has-patch       |
--------------------------+------------------------------------------------

Comment (by valendesigns):

 Replying to [comment:23 afercia]:
 > @valendesigns: this can't be done with JS.

 Here's a working patch that says otherwise. Please test patch
 [attachment:29958.6.diff].

 >
 > Thanks for the Sass part, real improvements are always welcome.

 No problem.

 > I would kindly suggest, for the future, to first discuss with the patch
 author before any changes.

 If we all waited to discuss every nuance of the patches we test, then
 things would never get done. I can appreciate that you created multiple
 patches for this ticket and your efforts do not go unnoticed, but it's
 open for anyone to iterate on. Especially as close as we are to 4.2 being
 released. Time is of the essence and when a patch sits for 3 weeks I'm
 inclined to refresh it while I'm testing it.

 Thank you for your comments, they really helped create a much better
 patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29958#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform