[wp-trac] [WordPress Trac] #29958: collapse menu keyboard accessibility

[WordPress Trac]

#29958: collapse menu keyboard accessibility
--------------------------+------------------------------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:                |     Version:  4.0
  Administration          |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  needs-        |
  testing has-patch       |
--------------------------+------------------------------------------------

Comment (by afercia):

 @valendesigns: this can't be done with JS. You have also to consider that
 there's a CSS media query that kicks in and then the menu will be folded.
 So with your changes, the menu will be collapsed and the label still be
 `<span class="collapse-button-label">Collapse menu</span>`.
 That's wrong and should be reverted. And that's the reason I've made it
 with a pure CSS solution. Not perfect, but works.

 Thanks for the Sass part, real improvements are always welcome.

 I would kindly suggest, for the future, to first discuss with the patch
 author before any changes. There may be issues that you didn't consider or
 didn't notice and stepping in to make changes without a clear view on the
 issue can be just a waste of time for both, me and you.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29958#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform