[wp-trac] [WordPress Trac] #31450: Add landmark roles to WordPress admin areas

[WordPress Trac]

#31450: Add landmark roles to WordPress admin areas
----------------------------+--------------------------------------------
 Reporter:  joedolson       |       Owner:  joedolson
     Type:  defect (bug)    |      Status:  assigned
 Priority:  high            |   Milestone:  4.2
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  accessibility, administration
----------------------------+--------------------------------------------

Comment (by afercia):

 Reported by one of our testers in the last testing session:
 >ARIA landmarks work great but I'm assuming there is nothing in the "main"
 area as it just goes into a navigation role.
 Investigating a bit on this and maybe we should disambiguate the 2
 navigation landmarks, for reference:
 http://www.w3.org/WAI/GL/wiki/Using_ARIA_landmarks_to_identify_regions_of_a_page
 ''There are cases when a particular landmark role could be used more than
 once on a page, such as on primary and secondary navigation menus. In
 these cases, identical roles should be disambiguated from each other using
 a valid technique for labelling regions (see examples below).''

 Basically, two same-type landmarks should be disambiguated using headings
 (if any) or aria-labelledby (if there are visible elements that can be
 referenced) or aria-label.

 I would propose to add `aria-label` attributes on the 2 navigation roles
 and remove a couple of duplicated roles, see attached refreshed patch.

 Tested witn Firefox + NVDA where pressing "d" jump to the next landmark.
 Please consider that NVDA automatically reads out the first text available
 after each landmark so it will read out:

 [press d]
 > Main menu navigation landmark
 > Skip to main content link
 [press d]
 > clickable Toolbar navigation landmark ''[see note 1]''
 > list with 5 items
 > About WordPress subMenu  link
 [press d]
 > out of list
 > main landmark
 > Help collapsed  link ''[see note 2]''
 [press d]
 > content info landmark
 > Thank you for creating with WordPress visited  link . ''[see note 3]''
 [press d]
 > no next landmark


 Notes:
 1. reads out "clickable" because of `tabindex="0"`, wondering if it's
 really needed
 2. the "Help" tab is the first text in the main content, see discussion
 about missing `h1` in the admin
 3. "." is read out as "dot" because it's outside the link

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31450#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform