[wp-trac] [WordPress Trac] #33196: ssh2_auth_pubkey_file() call can cause a fatal error because of non-existing key error in $this->options['password']

[WordPress Trac]

#33196: ssh2_auth_pubkey_file() call can cause a fatal error because of non-
existing key error in $this->options['password']
----------------------------+-----------------------------
 Reporter:  ehsanakhgari    |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Future Release
Component:  Filesystem API  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------------

Comment (by ehsanakhgari):

 Replying to [comment:2 dd32]:
 > Can you post the exact fatal error which occurs in this situation?

 In my local configuration, I got a "connection reset" error page in
 Firefox in all pages where WordPress was trying to update
 itself/plugins/themes.  After manual debugging using set_error_handler, I
 got an error message about the non-existing 'password' key in the options
 array.

 > Looking at the patch, it can probably be rewritten slightly to set
 `$this->options['password']` before the empty-password no-keys error
 checks (Assuming that the `$opt['password']` key is always set, and won't
 cause a notice in the current patch)

 OK, I'll do that!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33196#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform