[wp-trac] [WordPress Trac] #31403: Hardcoded Id in WP 4.1.1 Wpeditimage

WordPress Trac noreply at wordpress.org
Thu Jul 30 06:51:03 UTC 2015


#31403: Hardcoded Id in WP 4.1.1 Wpeditimage
--------------------------+------------------------------
 Reporter:  programmin    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  TinyMCE       |     Version:  4.1.1
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui, javascript
--------------------------+------------------------------

Comment (by programmin):

 Looks like it's worse in 4.3 RC, a bunch of code in wp-
 includes/js/tinymce/plugins/wordpress/plugin.js was changed to be
 dependent on the id_ifr element:
 {{{
 mceIframe = document.getElementById( editor.id + '_ifr' ),
 }}}

 Could this possibly be reworked for a more inline-friendly version? Was
 this rewritten for MCE 4.2?

 I'm surprised it would be changed to this because getElementById only
 works if the specific element is in the DOM of the page, never if it has
 been removed at the moment.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31403#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list