[wp-trac] [WordPress Trac] #32165: wp-db.php destructs all the multibyte characters
WordPress Trac
noreply at wordpress.org
Thu Jul 16 08:16:05 UTC 2015
#32165: wp-db.php destructs all the multibyte characters
--------------------------+-----------------------
Reporter: kjmtsh | Owner: pento
Type: defect (bug) | Status: reopened
Priority: high | Milestone: 4.2.3
Component: Database | Version: 4.1.2
Severity: blocker | Resolution:
Keywords: | Focuses:
--------------------------+-----------------------
Comment (by nbachiyski):
The patch looks mostly good, at least as far as I understood things, it
shouldn't break anything.
My biggest issue is that there isn't a test that breaks unless the `wp-
db.php` portion of the patch is applied. This way we don't have any
regression safety net.
Two other tiny things:
* Why did we move `$this->check_current_query = false;` to outside of the
loop?
* Is the comment `// Split the CONVERT() calls by charset, so we can make
sure the connection is right` still accurate?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/32165#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list