[wp-trac] [WordPress Trac] #32165: wp-db.php destructs all the multibyte characters

[WordPress Trac]

#32165: wp-db.php destructs all the multibyte characters
--------------------------+-----------------------
 Reporter:  kjmtsh        |       Owner:  pento
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  4.2.3
Component:  Database      |     Version:  4.1.2
 Severity:  blocker       |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------

Comment (by pento):

 The character set switching was put in place because of some bugs we found
 when testing the patch on WordPress.org, but I think we fixed it
 incorrectly - we decided to check by column character set, when we really
 should've been using the existing character set, and allowing MySQL to do
 the conversion.

 This more accurately reflects how queries are run - if some code needs to
 change the character set, it'll change using `$wpdb->set_charset()`, then
 run the query.

 Because we're no longer switching character set for the sanity checks,
 this will also be fine if someone decides to use `mysqli_set_charset()`,
 instead.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32165#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform