[wp-trac] [WordPress Trac] #30891: Unchecked property overloading is detrimental to OOP.
WordPress Trac
noreply at wordpress.org
Sun Jan 11 00:12:49 UTC 2015
#30891: Unchecked property overloading is detrimental to OOP.
--------------------------+------------------
Reporter: aercolino | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.2
Component: General | Version: 4.0
Severity: normal | Resolution:
Keywords: | Focuses:
--------------------------+------------------
Comment (by wonderboymusic):
In [changeset:"31139"]:
{{{
#!CommitTicketReference repository="" revision="31139"
`WP_Ajax_Response` has one property only, `$responses`. It was public
until [28508], when it became `private` in name only. Is it worth 4 magic
methods to pretend that this property is `private`? It is not.
Make it `public` and remove the magic methods.
See #30891.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30891#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list