[wp-trac] [WordPress Trac] #30891: Unchecked property overloading is detrimental to OOP.

[WordPress Trac]

#30891: Unchecked property overloading is detrimental to OOP.
--------------------------+------------------
 Reporter:  aercolino     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  General       |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------

Comment (by wonderboymusic):

 In [changeset:"31138"]:
 {{{
 #!CommitTicketReference repository="" revision="31138"
 In `WP_Error`:

 * `wp_send_json_error()` accesses `$errors` on an instance, it must be
 `public`
 * `$error_data` is a local message cache for error codes and doesn't
 particularly hide info, would be the only non-public field or method in
 the class

 Make `$errors` and `$error_data` public and remove magic methods.

 See #30891.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30891#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform