[wp-trac] [WordPress Trac] #30168: Collapse additional avatar settings if avatars are disabled
WordPress Trac
noreply at wordpress.org
Wed Jan 7 18:02:48 UTC 2015
#30168: Collapse additional avatar settings if avatars are disabled
-------------------------+---------------------------------
Reporter: markjaquith | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.2
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, administration
-------------------------+---------------------------------
Comment (by nacin):
I don't think we should try to do this to avoid external services hits.
That could be better achieved with a filter on default_avatar_select
and/or avatar_defaults and/or in get_avatar() itself. Patch looks good,
though perhaps we should simplify it so a 'hidden' class is included with
'avatar-settings', and then all we do is $('.avatar-
settings').toggleClass('hidden'). That also means there definitely won't
be any noticeable jumps during load, though in practice this might be
tough to notice.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30168#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list