[wp-trac] [WordPress Trac] #30168: Collapse additional avatar settings if avatars are disabled

WordPress Trac noreply at wordpress.org
Wed Jan 7 05:09:05 UTC 2015

#30168: Collapse additional avatar settings if avatars are disabled
 Reporter:  markjaquith  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.2
Component:  Comments     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, administration

Comment (by valendesigns):

 Replying to [comment:6 helen]:
 > Was tweaking a couple things, looking to commit (see
 [attachment:30168.5.diff]), but noticed something that's a little funky -
 when avatars are off, the previews for generated avatars don't show. Seems
 understandable, especially when trying not to hit any external services,
 but it jumped out to me once I was toggling the section "on". Curious if
 we think it's worth addressing, or if it's really separate.

 I don't think this will stop the external hit even though they are hidden.
 However, I feel like the point of the patch is to hide all avatar settings
 and should be the expected behavior when `show_avatars` is not checked. It
 probably feels funky because we're so use to seeing those generated
 avatars when you visit the Discussion page. Just my 2¢.

 I'm glad to see this is going to make it into 4.2 though!

Ticket URL: <https://core.trac.wordpress.org/ticket/30168#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list