[wp-trac] [WordPress Trac] #28975: Improve do_settings_fields() by including field ID on <tr> table row

[WordPress Trac]

#28975: Improve do_settings_fields() by including field ID on <tr> table row
----------------------------+---------------------------------
 Reporter:  Jonnyauk        |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  Administration  |     Version:  4.0
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, administration
----------------------------+---------------------------------
Changes (by helen):

 * keywords:  has-patch dev-feedback => has-patch
 * milestone:  Awaiting Review => 4.2


Comment:

 I'm okay with this, especially in light of #30168. I don't think it ties
 us too much to the markup elements - short of predicting the future, as
 far as I can see any changes would still include a wrapper element around
 a given field group. If somebody starts targeting things in ways that are
 tied to the specific structure, I don't see future breakage being
 catastrophic, plus there are plenty of other things that would likely
 break that we can't help anyway, so plugin/theme updates would be a
 necessity.

 Going to simplify to avoid the first else, but otherwise looks good.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28975#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform