[wp-trac] [WordPress Trac] #28975: Improve do_settings_fields() by including field ID on <tr> table row

[WordPress Trac]

#28975: Improve do_settings_fields() by including field ID on <tr> table row
------------------------------------+---------------------------------
 Reporter:  Jonnyauk                |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Administration          |     Version:  4.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  ui, administration
------------------------------------+---------------------------------
Changes (by valendesigns):

 * keywords:  has-patch close => has-patch dev-feedback


Comment:

 I've refreshed the patch and cleaned up the code to be inline with the
 standards. Now that #30168 is in Core we cannot add additional avatar
 settings to the UI in `options-discussion.php` that are automatically
 toggled on and off without applying this patch. For example, lets say I
 wanted to create an avatar caching plugin and add a setting right after
 the other avatar settings. When someone toggles those settings my custom
 one will still be displayed, even though I want it to be hidden. The only
 recourse I have is to duplicate the JS and cobble together a solution
 without a clearly defined CSS selector.

 Additionally, we really do need a way to add some sort of specificity to
 the `tr` or `div` or whatever future markup we use beyond the avatar
 settings issue. In order to easily manipulate the DOM with JS there has to
 be a class or ID we can select, or we end up searching and guessing which
 is not consistent enough.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28975#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform