[wp-trac] [WordPress Trac] #31248: Optimizations for wp-admin/includes/template.php

[WordPress Trac]

#31248: Optimizations for wp-admin/includes/template.php
--------------------------+------------------------------
 Reporter:  ipm-frommen   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  docs, template
--------------------------+------------------------------

Comment (by ipm-frommen):

 Replying to [comment:4 DrewAPicture]:
 > there are code changes mixed in with doc changes. Pretty much all the
 cases where you've changed default values for parameters or expected
 returns within functions would require also having accompanying unit
 tests.

 Well, what these changes are all about is that the overall behavior of the
 code/functions does not change at all, which means that the existing unit
 tests are all working absolutely fine.

 > I would suggest splitting the docs changes from the code changes into
 separate patches and probably separate tickets.

 Okay, that's why I asked if something was ''wrong''; I silently assumed
 something like this. I will update ticket and patch, and open a new ticket
 (or maybe two) for parts of the changes.

 I just wasn't sure what was best: one ticket handling a bunch of changes
 in a single file, or several tickets for different changes in the same
 file. Anyway, now I know what you prefer. Thanks. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31248#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform