[wp-trac] [WordPress Trac] #31248: Optimizations for wp-admin/includes/template.php

[WordPress Trac]

#31248: Optimizations for wp-admin/includes/template.php
--------------------------+------------------------------
 Reporter:  ipm-frommen   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  docs, template
--------------------------+------------------------------

Comment (by DrewAPicture):

 Just a cursory glance at the patch reveals that there are code changes
 mixed in with doc changes. Pretty much all the cases where you've changed
 default values for parameters or expected returns within functions would
 require also having accompanying unit tests.

 So I would suggest splitting the docs changes from the code changes into
 separate patches and probably separate tickets. we're trying to move away
 from these types of general-purpose optimizations unless it's a blessed
 task.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31248#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform