[wp-trac] [WordPress Trac] #29820: Smooth installation and updating of plugins and themes

[WordPress Trac]

#29820: Smooth installation and updating of plugins and themes
-----------------------------+---------------------------------------------
 Reporter:  markjaquith      |       Owner:
     Type:  task (blessed)   |      Status:  new
 Priority:  high             |   Milestone:  4.2
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  ux-feedback      |     Focuses:  ui, javascript, administration
-----------------------------+---------------------------------------------

Comment (by afercia):

 Please consider handling broken plugins or plugins that output something
 during automatic activation, for example:

 - go in the "Beta Testing" tab and install "Customize Partial Refresh"
 - the plugin throws an Exception during activation (see the response in
 your browser dev-tools)
 - so, no JSON response: just text/html and no responseJSON object
 - you get a JS alert "Installation failed" and the button hangs on
 "Installing..."
 - refresh the page, the plugin is actually installed but not activated

 For reference, the error details:

 {{{
 Fatal error: Uncaught exception 'Exception' with message 'Class not
 located within a directory tree containing 'plugins':
 /src/wp-content/plugins/customize-partial-refresh/php/class-wp-customize-
 partial-refresh-plugin.php' in /src/wp-content/plugins/customize-partial-
 refresh/php/class-wp-customize-partial-refresh-plugin.php:92
 Stack trace: #0 /src/wp-content/plugins/customize-partial-refresh/php
 /class-wp-customize-partial-refresh-plugin.php(31):
 WP_Customize_Partial_Refresh_Plugin->locate_plugin()
 #1 /src/wp-content/plugins/customize-partial-refresh/customize-partial-
 refresh.php(33): WP_Customize_Partial_Refresh_Plugin->__construct()
 #2 /src/wp-admin/includes/plugin.php(542): include_once({mycheckoutpath})
 #3 /src/wp-admin/includes/ajax-actions.php(2872): activate_plugin
 ('customize-parti...')
 #4 [internal function]: wp_ajax_install_plugin('')
 #5 /src/wp-includes/plugin.php(496): call_user_func_array(' in /src/wp-
 content/plugins/customize-partial-refresh/php/class-wp-customize-partial-
 refresh-plugin.php on line 92
 }}}

 Btw the point is there's always a chance users will install a broken
 plugin, maybe the automatic activation should be reconsidered or should
 handle this kind of errors.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29820#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform