[wp-trac] [WordPress Trac] #35175: Page parameter no longer works in wp_list_comments

[WordPress Trac]

#35175: Page parameter no longer works in wp_list_comments
-------------------------------------+--------------------
 Reporter:  smerriman                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.4.1
Component:  Comments                 |     Version:  4.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:  reporter-feedback => has-patch needs-testing
 * milestone:  Awaiting Review => 4.4.1


Comment:

 Thanks for having another look, @smerriman.

 I think you're correct about `per_page`. On a second look,
 `reverse_top_level` should be properly respected by enforcing that `order`
 of the additional comment query is always `ASC`, matching the order of the
 comment query in `comments_template()`; the logic later in
 `wp_list_comments()` plus the walker should handle the rest. Unit tests in
 [attachment:35175.2.diff] demonstrate both of these.

 @smerriman Can you test this against your actual use cases? I have run a
 number of tests, but there are many possible configurations, and I want
 some validation that I haven't missed anything.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35175#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform