[wp-trac] [WordPress Trac] #35175: Page parameter no longer works in wp_list_comments

[WordPress Trac]

#35175: Page parameter no longer works in wp_list_comments
-------------------------------+------------------------------
 Reporter:  smerriman          |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Comments           |     Version:  4.4
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------

Comment (by smerriman):

 Yep, that's obviously not optimal performance wise as you mentioned, but
 solely from the perspective of backwards compatibility I think that sort
 of idea should suffice as a quick fix.

 A couple of points:

 - I think you'll want `is_singular` to handle custom post types rather
 than just posts/pages.
 - Now that I think about it, the problem is more widespread than simply
 the page parameter - anything that affected the query will have issues
 too. This applies to `per_page` and `reverse_top_level` at least, and I
 think maybe `reverse_children` as well - even `type`? `max_depth` is still
 handled correctly by the walker I believe.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35175#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform