[wp-trac] [WordPress Trac] #28365: wp multisite, changed root blog has issues

[WordPress Trac]

#28365: wp multisite, changed root blog has issues
--------------------------------+------------------------------
 Reporter:  velegno             |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Networks and Sites  |     Version:  3.5
 Severity:  normal              |  Resolution:
 Keywords:  close               |     Focuses:  multisite
--------------------------------+------------------------------
Changes (by jeremyfelt):

 * keywords:   => close
 * version:  3.9.1 => 3.5


Comment:

 This one is tough. :)

 * [28123] turned off `ms-files.php` by default and introduced a lot of the
 current logic used to determine upload directory. At that point (3.5),
 changing `BLOG_ID_CURRENT_SITE` would result in the issue described in
 this ticket.
 * In 3.7, [25148] used the newly introduced `is_main_network()` to prevent
 the main sites on multiple networks from sharing the same `wp-
 content/uploads/` directory.

 To provide loose support for the change of a main network's main site ID,
 we could check for `1 == get_current_blog_id()` rather than
 `is_main_site()`. The check now is really more about not breaking the
 initial uploads directory from the single site that existed before and not
 about enforcing a bare `uploads/` directory for the main site.

 That said, this is all pretty edge case and if we adjust the logic now we
 may suddenly break some configs that have worked around it over the last
 several years.

 I lean toward wontfix as the `upload_dir` filter can be used to adjust the
 directory as needed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28365#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform