[wp-trac] [WordPress Trac] #35023: get_field_name() returns a bad field name if you pass it "display][avatar_size"

[WordPress Trac]

#35023: get_field_name() returns a bad field name if you pass it
"display][avatar_size"
-------------------------------------------------+-------------------------
 Reporter:  pbearne                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.4.1
Component:  Widgets                              |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-        |     Focuses:
  opinion                                        |  administration
-------------------------------------------------+-------------------------

Comment (by pbearne):

 I hear you, but I am in a real bind I have pushed a new version of the
 plugin that includes a workaround. but any installs with an old version on
 WP 4.4 will break.

 The function currently uses a test that looks string with a "[" but
 assumes that it closes with a closing "]"

 The #rd patch tests for the closing "]" which is safer that just testing
 for an opening "[" and handles "foo]" as well just incase

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35023#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform