[wp-trac] [WordPress Trac] #25449: wp_upload_dir() doesn't support https

[WordPress Trac]

#25449: wp_upload_dir() doesn't support https
-------------------------------------------+------------------------------
 Reporter:  ryanhellyer                    |       Owner:
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  Awaiting Review
Component:  Upload                         |     Version:  3.8
 Severity:  major                          |  Resolution:
 Keywords:  has-patch needs-testing https  |     Focuses:
-------------------------------------------+------------------------------
Changes (by joemcgill):

 * keywords:  has-patch, needs-testing, https => has-patch needs-testing
               https


Comment:

 Reading back through the history of #15928 and #32112 makes me wonder if
 the best approach, as we prepare to be HTTPS first, is to remove the
 `is_admin()` checks that were introduced in r32342 and instead, add logic
 to `get_image_tag()` to always use HTTP URLs when the site url is setup
 using an HTTP scheme.

 That way, any URL that is built dynamically from `wp_uploads_dir()` would
 use a scheme relative to the context from which it was called, and we
 still manage the exceptions when writing image URLs to post content.

 This strategy would also address #34109.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25449#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform