[wp-trac] [WordPress Trac] #25449: wp_upload_dir() doesn't support https

[WordPress Trac]

#25449: wp_upload_dir() doesn't support https
-------------------------------------+------------------------------
 Reporter:  ryanhellyer              |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Upload                   |     Version:  3.8
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------
Changes (by thomaswm):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Since [32384], `wp_get_attachment_url` returns HTTPS URLs on the front-end
 if `is_ssl()` is true. This could also be done in `wp_upload_dir`.

 [attachment:25449.diff] moves the code, which sets the URL scheme on the
 front-end, from `wp_get_attachment_url` to `wp_upload_dir`. This should be
 safe because it does not affect URLs which are generated in the admin
 backend.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25449#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform