[wp-trac] [WordPress Trac] #33184: Customizer: unnecessary events bound on some section titles

WordPress Trac noreply at wordpress.org
Wed Aug 5 00:19:38 UTC 2015


#33184: Customizer: unnecessary events bound on some section titles
--------------------------+----------------------------------------
 Reporter:  afercia       |       Owner:  helen
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.3
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  accessibility, javascript
--------------------------+----------------------------------------

Comment (by celloexpressions):

 I don't think we can assume the presence of `tabindex="0"`, as plugins may
 be implementing their own accordions without that markup. We could make
 changes within the available menu items panel, but not anywhere else
 within menus, and that panel should use accordion.js. I'm still very
 against the current setup with the search, it really should be an
 accordion like the rest of the panel, and apparently it was not properly
 changed if there are issues there now with it conflicting with the
 accordion events.

 The only viable solution that I can think of would be to use the `cannot-
 expand` class as needed to inform accordion.js to bail early in the
 appropriate places. However, `accordion.js` should not be acting at all on
 the main Customizer panel, if it is, can we require use of `.accordion-
 container`, or whatever is documented in the required markup at the
 beginning of that file? Or otherwise introduce an equivalent class to
 prevent that file from attaching events where we don't want them.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33184#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list