[wp-trac] [WordPress Trac] #32112: wp_get_attachment_url returns https when it should not

[WordPress Trac]

#32112: wp_get_attachment_url returns https when it should not
-------------------------------------+---------------------------
 Reporter:  zabatonni                |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.2.2
Component:  Media                    |     Version:  4.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by boonebgorges):

 Thanks for testing, khlo. You're right that those links should also go to
 the canonical, non-SSL URLs. See [attachment:32112.2.diff].

 This issue is showing pretty clearly how it's a mess that we use the same
 function as a template/theme function - where it should be context-
 sensitive - and as a business function for getting canonical URLs - where
 it should not be context-sensitive.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32112#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform