[wp-trac] [WordPress Trac] #32112: wp_get_attachment_url returns https when it should not

[WordPress Trac]

#32112: wp_get_attachment_url returns https when it should not
-------------------------------------+---------------------------
 Reporter:  zabatonni                |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.2.2
Component:  Media                    |     Version:  4.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by khlo):

 Hey @boonebgorges

 Nice patch - thanks! I'm testing this in production right now.
 * Images insert as expected with a http-scheme URL.
 * On the 'Insert Media' screen:
   * If the **Link to: Media file** option is selected, it still links to
 https version. I'm not so bothered about this myself as I don't normally
 use this option. However, it's a little bit confusing as the hyperlink is
 intended for users on the front-end (hence, it should probably respect the
 http schema which has been specified for the front-end).
   * Same goes for the **URL** listed on the Insert Media screen.

 Aside from that, it's generally working well and images are no longer
 causing a problem.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32112#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform