[wp-trac] [WordPress Trac] #22839: Toggle spinners by adding/removing a class instead of show()/hide()

[WordPress Trac]

#22839: Toggle spinners by adding/removing a class instead of show()/hide()
----------------------------+---------------------
 Reporter:  cdog            |       Owner:  helen
     Type:  defect (bug)    |      Status:  closed
 Priority:  low             |   Milestone:  4.2
Component:  Administration  |     Version:  3.4.2
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |     Focuses:  ui
----------------------------+---------------------

Comment (by jadpm):

 Please note that changing the styles for the spinners from a display:none
 to a visibility:hidden might (and in fact does) have consecuences in third
 party plugins, as I just found out in one I work on.

 In our particular case, we are adding the spinner span dinamically, and
 jQuery-show()-ing/hide()-ing it on demand, which does not have any effect
 over the visibility property. Not a big deal, we plan to implement out own
 spinner span soon, but this change might affect other too. Worth
 mentioning :-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22839#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform