[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

WordPress Trac noreply at wordpress.org
Thu Apr 2 21:35:14 UTC 2015


#31233: Dismissable admin notices
-----------------------------------+--------------------------------
 Reporter:  ryan                   |       Owner:  helen
     Type:  task (blessed)         |      Status:  reopened
 Priority:  normal                 |   Milestone:  4.2
Component:  Administration         |     Version:  4.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 4.2-strings  |     Focuses:  ui, accessibility
-----------------------------------+--------------------------------

Comment (by helen):

 Replying to [comment:55 valendesigns]:
 > * I added `!important` to the right padding because text was being
 overlapped by the dismiss button.

 Why exactly does that need to be !important? If it really does need to be
 (I sort of hope not), then it needs to be documented in the CSS.

 > * By changing the notice paragraph margin from `0.5em` to `0.499em` I
 was able to solve the issue with Firefox rounding up an extra pixel from
 38 to 39, and without effecting other browsers or devices.

 If we're relying on pixels here, then let's define pixels.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list