[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

[WordPress Trac]

#31233: Dismissable admin notices
-----------------------------------+--------------------------------
 Reporter:  ryan                   |       Owner:  helen
     Type:  task (blessed)         |      Status:  reopened
 Priority:  normal                 |   Milestone:  4.2
Component:  Administration         |     Version:  4.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 4.2-strings  |     Focuses:  ui, accessibility
-----------------------------------+--------------------------------
Changes (by valendesigns):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @helen I've uploaded patch [attachment:31233.21.2.diff], which returns the
 UI back to the way things were in 31233.21.diff and without any browser
 hacks.

 * I added `!important` to the right padding because text was being
 overlapped by the dismiss button.
 * By changing the notice paragraph margin from `0.5em` to `0.499em` I was
 able to solve the issue with Firefox rounding up an extra pixel from 38 to
 39, and without effecting other browsers or devices.
 * The width and height could be removed on the button.
 *  I corrected the padding.
 * Moved the button position `right: 1px` so the highlight lines up with
 the right edge, which looks better.
 * Added a separate `.notice-dismiss:before` which corrects the font size
 and keeps the button from shifting in IE when you click it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform