[wp-trac] [WordPress Trac] #29610: FTPext Filesystem class can't detect isWritable, isReadable correctly
WordPress Trac
noreply at wordpress.org
Wed Sep 10 02:03:45 UTC 2014
#29610: FTPext Filesystem class can't detect isWritable, isReadable correctly
-----------------------------+-----------------------------
Reporter: programmin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Upgrade/Install | Version: 4.0
Severity: normal | Keywords:
Focuses: |
-----------------------------+-----------------------------
The wp-admin/includes/class-wp-filesystem-ftpext.php doesn't actually
detect if a file is readable or writable:
{{{
public function is_readable($file) {
return true;
}
public function is_writable($file) {
return true;
}
}}}
even though it's parsing permissions ('perms') in another part of that
file.
The lack of this feature is also likely the main reason it's not actually
checking file permissions are such that a wp-update can be copied? In wp-
admin/includes/update-core.php:
{{{
// If we're using the direct method, we can predict write failures that
are due to permissions.
if ( $check_is_writable && 'direct' === $wp_filesystem->method ) {
.... checks permissions won't make upgrade choke ...
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29610>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list