[wp-trac] [WordPress Trac] #29469: Media library: list mode trash view doesn't display trashed items

[WordPress Trac]

#29469: Media library: list mode trash view doesn't display trashed items
--------------------------+-----------------------------
 Reporter:  afercia       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Media         |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Noticed a couple of issues after [changeset:"29625"]:

 1)
 enable media trash in your wp-config.php setting `define('MEDIA_TRASH',
 true);`
 trash one or more media
 go in the list mode trash view: no items are displayed (see first
 screenshot)

 [[Image(http://i.imgur.com/KZwbOPa.png)]]

 in class WP_Media_List_Table, is_trash is still looking for "status" which
 isn't used anymore, should check for "attachment-filter".
 Looks like pretty easy to fix but I've read you want to maintain some
 back-compat for `views_upload` links (see #28946) and that will probably
 require some decisions I can't make, only lead devs can do that :)

 2)
 say it's fixed and you're now in a situation like the one in the second
 screenshot:

 [[Image(http://i.imgur.com/MWhVJ0j.png)]]

 when you have lots of trashed items you may be tempted to do a search:
 don't do that :) as soon as you press Enter to trigger your search,
 "delete_all" will be set and you will (unintentionally) permanently empty
 the trash.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29469>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform