[wp-trac] [WordPress Trac] #12668: Better support for custom comment types

[WordPress Trac]

#12668: Better support for custom comment types
----------------------------------------+------------------------------
 Reporter:  ptahdunbar                  |       Owner:  ptahdunbar
     Type:  enhancement                 |      Status:  reopened
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Comments                    |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+------------------------------

Comment (by dancameron):

 Replying to [comment:54 boonebgorges]:
 > There are pieces of this that I would be happy to help shepherd through
 the process

 Thank you!

 > ...it would be nice if they were accompanied by a succinct statement
 about what just what it is that we're trying to accomplish.

 I'll try my best to be as descriptive as possible with my patches.

 > Yes, this. Adding piecemeal support to `get_approved_comments()` is
 unappealing. We'll need unit tests for that function before rewriting its
 internals, though.

 I'd be happy to do this since I've never done WP core unit tests before
 (forgive me later).

 > (Also, in `WP_Comment_Query`, be sure to `array_map( 'esc_sql',
 $this->query_vars['type'] )`.)

 Done. Thanks, this is something I actually forgot to bring up because I
 didn't know what callback to use.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12668#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform