[wp-trac] [WordPress Trac] #30334: New Precommit Grunt Task to avoid __DIR__ and 5.3+ stuff in Core.
WordPress Trac
noreply at wordpress.org
Fri Nov 14 03:07:25 UTC 2014
#30334: New Precommit Grunt Task to avoid __DIR__ and 5.3+ stuff in Core.
------------------------------+----------------------
Reporter: georgestephanis | Owner: jorbin
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Build/Test Tools | Version: trunk
Severity: minor | Resolution: wontfix
Keywords: has-patch close | Focuses:
------------------------------+----------------------
Changes (by jorbin):
* status: assigned => closed
* resolution: => wontfix
* milestone: 4.1 =>
Comment:
I agree with Nacin. As I had mentioned in slack earlier: :At first I
really liked the idea of using grunt-search, but I think phpcodesniffer is
actually what we should be using in this situation. I would rather us
work on getting #30153 done and then we can write a sniff for __dir__ if
one does not exist already.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30334#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list