[wp-trac] [WordPress Trac] #30334: New Precommit Grunt Task to avoid __DIR__ and 5.3+ stuff in Core.

WordPress Trac noreply at wordpress.org
Fri Nov 14 03:02:51 UTC 2014


#30334: New Precommit Grunt Task to avoid __DIR__ and 5.3+ stuff in Core.
------------------------------+-----------------------
 Reporter:  georgestephanis   |       Owner:  jorbin
     Type:  enhancement       |      Status:  assigned
 Priority:  normal            |   Milestone:  4.1
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  minor             |  Resolution:
 Keywords:  has-patch close   |     Focuses:
------------------------------+-----------------------
Changes (by nacin):

 * keywords:  has-patch => has-patch close


Comment:

 Is this a good use case of Grunt? Seems more like Codesniffer or PHP 5.2
 syntax checking. Though `__DIR__` doesn't trigger a syntax error in 5.2,
 `__DIR__` isn't the common issue. It's some other PHP 5.3-ism, usually,
 and ones that trigger a fatal or syntax error.

 The number of times a `__DIR__` has entered core is, best I can tell from
 a search of commit logs, 1.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30334#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list