[wp-trac] [WordPress Trac] #29988: Twenty Fifteen: Use JS/postMessage to update the color scheme instead of triggering a page refresh

WordPress Trac noreply at wordpress.org
Thu Nov 6 18:47:33 UTC 2014


#29988: Twenty Fifteen: Use JS/postMessage to update the color scheme instead of
triggering a page refresh
------------------------------------+-----------------------------
 Reporter:  avryl                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Bundled Theme           |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  javascript
------------------------------------+-----------------------------

Comment (by bradyvercher):

 Replying to [comment:22 ocean90]:
 >
 > Probably because it's a bit hidden in your patch. :)

 Sorry, didn't mean to make that hidden!

 Replying to [comment:23 westonruter]
 >
 > Nice one, bradyvercher!
 >
 > One caution: if the user were able to change one of those settings that
 comprise the color_scheme_css setting outside the Customizer, for instance
 in the Appearance > Background admin page, then the JS-computed
 color_scheme_css would no longer be valid, right? We can help prevent that
 if #25569 and #25571 can land.

 Thanks! That would be the only problem I can see.

 The background screen doesn't matter because it outputs its own `<style>`
 tag that will override the theme's styles.

 That leaves the header color, which doesn't output its own CSS. Can we
 just disable the color control on that screen... or add a link to the
 Customizer? There also seems to be a problem with that color field not
 showing unless the "Show header text with your image" checkbox is toggled.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29988#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list