[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28305"]:
 {{{
 #!CommitTicketReference repository="" revision="28305"
 In `wp-admin/includes/upgrade.php`, remove dead code:

 * In `maybe_create_table()` and `maybe_add_column()`, the response of
 `$wpdb->query()` is set to a variable that is never used.
 * In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a
 variable is set that is not used. This function appears to be a copy-paste
 of `make_db_current()`'s `dbDelta()` call but is meant to return nothing,
 and still does not.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform